[M] Change in coreboot[master]: src/drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init

[Paul Menzel (Code Review)]

Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Johnny Lin, Christian Walter, Nill Ge, TangYiwei.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69310 )

Change subject: src/drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init
......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/69310/comment/1c0f53da_5f14fe77 
PS2, Line 7: src/
Please remove.

https://review.coreboot.org/c/coreboot/+/69310/comment/27d57797_cc5dcb17 
PS2, Line 8: 
Please describe the problem in detail. What board, what BMC firmware versions, …?

https://review.coreboot.org/c/coreboot/+/69310/comment/6ce3c962_6b28cec8 
PS2, Line 11: 
Please mention the solution (retrying up to ten times and waiting one second), and how you determined these values.

Holding up the boot up to ten seconds is not wanted in coreboot. This is clearly a workaround. Were you able to debug the actual cause?

File src/drivers/ipmi/ipmi_kcs_ops.c:

https://review.coreboot.org/c/coreboot/+/69310/comment/f4e278f4_bbde056b 
PS2, Line 130: 	}
Please use coreboot’s stopwatch framework. Maybe `wait_ms()` can be used.