Attention is currently required from: Felix Singer, Julius Werner, Jérémy Compostella.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82645?usp=email )
Change subject: tree: Add smbios_processor_type
......................................................................
Patch Set 2:
(1 comment)
File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/82645/comment/d0144b2d_2031a4a8?usp... :
PS1, Line 504: SMBIOS_PROCESSOR_TYPE_DSP = 0x05
Missing comma
Thx
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82645?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46f799ad255993ac42dab11b5c1d2608daa52b42
Gerrit-Change-Number: 82645
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sat, 25 May 2024 10:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de