Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58649 )
Change subject: acpi/acpigen.c: Remove weak gpio definition
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Might be able to use intel/common/block/acpi/gpio functions for older intel platforms too? would need to double check
Gpio's are a bit different but regardsless there is no need for it. It might be more interesting to optimize out these things when there not used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1db0a8f01eaecf012e5444c03f8d4e2bb6e42a77
Gerrit-Change-Number: 58649
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 27 Oct 2021 16:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment