[XS] Change in coreboot[main]: drivers/spi/spi_flash: make 'do_spi_flash_cmd' available to other files - coreboot-gerrit

5 Nov 2024


      Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/84789?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/spi/spi_flash: make 'do_spi_flash_cmd' available to other files
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
...
or would it be better to add a new function that can be called from other compilation units in the s […]
discussed this one with Matt and we both think that introducing 'spi_flash_cmd_multi' would be the better way; will update the patch
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84789?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1f3872463249240c0a32e2825e4302894e856b2e
Gerrit-Change-Number: 84789
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Ana Carolina Cabral
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Nov 2024 16:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de