Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78076?usp=email )
Change subject: {lib, ec/google}: Add weak implementation for get_lid_switch()
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/switches.c:
https://review.coreboot.org/c/coreboot/+/78076/comment/49b0d08e_3ab850db :
PS1, Line 9: if (!CONFIG(VBOOT_LID_SWITCH))
Oh, right because Chromeboxes still have ECs. Okay that makes sense. I wonder if we should flip it around though (or just make it `default y`). It seems cumbersome that every laptop mainboard needs to select this explicitly when 90% of our boards are laptops.
that is valid point, ideally VBOOT_LID_SWITCH should be default y if VBOOT is enabled and then chromeboxes and bases can overrides that to N.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78076?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8847bc6f08f5d9cecf9d9ddaf33c44bd40491e98
Gerrit-Change-Number: 78076
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 26 Sep 2023 18:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment