Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb/clevo/tgl-u: add new board L14xMU ......................................................................
Patch Set 14:
(6 comments)
File src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/ff4d424f_5a83b86d PS14, Line 94: PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* I2C1_SDA / PCH_I2C_SDA (retimer rom) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/c7f64b87_df26fb54 PS14, Line 95: PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), /* I2C1_SCL / PCH_I2C_SCL (retimer rom) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/ab6cc145_57557364 PS14, Line 99: PAD_NC(GPP_C23, UP_20K), /* GPP_C23 / PCH_GPP_C23 (WLAN_WAKEUP#) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/99a23afe_304d4aad PS14, Line 104: PAD_NC(GPP_D2, NONE), /* LEDKB_DET# (unused; not sold w/o KBLED) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/047ca0e3_ed248ae1 PS14, Line 107: PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* SRCCLKREQ0# / SSD1_CLKREQ# (for SSD2!) */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/258f39f4_a1c049ba PS14, Line 110: PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* SRCCLKREQ3# / SSD2_CLKREQ# (for SSD1!) */ line over 96 characters
-
build bot (Jenkins) (Code Review)