Change in ...coreboot[master]: sdm845: Add SPI QUP driver - coreboot-gerrit

3 May 2019


      Akash Asthana has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27483 )
Change subject: sdm845: Add SPI QUP driver
......................................................................
Patch Set 51:
Need clarification:
We are using a common header file(qcom_qup_se.h) across I2C, SPI and UART drivers in CB.
We need to have a similar common header in DC as well for I2C and SPI driver. What would be the ideal location to keep those common files (qcom_qup_se.h, qcom_qup_se.c) in DC.
We are thinking to create a new folder "include" inside depthcharge/src/drivers/bus, to keep all the common files there. What do you say about it?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/27483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54
Gerrit-Change-Number: 27483
Gerrit-PatchSet: 51
Gerrit-Owner: T.Michael Turney tturne@codeaurora.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: T.Michael Turney tturne@codeaurora.org
Gerrit-Reviewer: Vin Kamath vink@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Fri, 03 May 2019 10:56:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment