Change in coreboot[master]: soc/intel/common/timer: Make TSC frequency calculation dynamically
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35148 )
Change subject: soc/intel/common/timer: Make TSC frequency calculation dynamically ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35148/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35148/9//COMMIT_MSG@16 PS9, Line 16: On SKL/KBL/CML CPUID.15h.ecx = nominal core crystal clock = 0 Hz
isn't that i have added in above line […]
Thanks. I didn't get the relation between the two paragraphs and it's much clearer to me now.
Just to make sure I understand correctly:
Normally 15h is used for the crystal clock. SKL/KBL/CML report 0 there, so 16h is used instead (in favor to using a static table like the code did so far). Correct?
https://review.coreboot.org/c/coreboot/+/35148/10/src/soc/intel/common/block... File src/soc/intel/common/block/timer/timer.c:
https://review.coreboot.org/c/coreboot/+/35148/10/src/soc/intel/common/block... PS10, Line 124: calculate We don't calculate anything in that function, but (according to comments) only return the bus frequency. That might be enough, but then the comment should say so.
-
Patrick Georgi (Code Review)