Attention is currently required from: Wisley Chen.
Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/70171
to review the following change.
Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ......................................................................
mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
Adjust scl_lcnt, scl_hcnt, sda_hold value for I2C5 to meet touchpad SPEC.
BUG=b:260540852 BRANCH=firmware-brya-14505.B TEST=build, checked TP function work normally, and measure the timing meet SPEC
Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com --- M src/mainboard/google/brya/variants/anahera/overridetree.cb 1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/70171/1
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb index df7f632..1773e0e 100644 --- a/src/mainboard/google/brya/variants/anahera/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb @@ -66,7 +66,12 @@ .speed = I2C_SPEED_FAST, .rise_time_ns = 650, .fall_time_ns = 400, - .data_hold_time_ns = 50, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 170, + .scl_hcnt = 70, + .sda_hold = 40, + } }, }" register "tcc_offset" = "3" # TCC of 97C