Attention is currently required from: ChiaLing, Paul Menzel, Reka Norman, Ryan Lin, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75406?usp=email )
Change subject: soc/intel/common: Add PsysPl1 support
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/75406/comment/332d8c1f_efd14354 :
PS1, Line 160: tdp_psyspl1
We can use psyspl1 to make performance more efficient. […]
A couple more questions:
1. I thought it always uses the most restrictive limits, so it would take the minimum of PL1 and PsysPl1. So in your example if PsysPL1 is 31W, it would still limit the CPU power to PL1. Is that not right? Or does it ignore PL1 if PSYS is enabled (and in that case why do we still set PL1?)
2. Should PsysPl1 be set to the total system thermal capacity? If so, that will be much lower than 31W on dibbi since it's fanless, e.g. maybe 6W?
https://review.coreboot.org/c/coreboot/+/75406/comment/76580c6d_51081fe1 :
PS1, Line 169: wrmsr(MSR_PLATFORM_POWER_LIMIT, limit);
I think line 129 to 150 already set pl1.
Line 129 to 150 is setting MSR_PKG_POWER_LIMIT. I was talking about bits 23:17 in MSR_PLATFORM_POWER_LIMIT (PsysPL1 time window, not PL1 time window).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51907859956631d5f54ba8237d92586431fe17b7
Gerrit-Change-Number: 75406
Gerrit-PatchSet: 3
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-CC: Super Ni
super.ni@intel.com
Gerrit-CC: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 03:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@google.com
Comment-In-Reply-To: ChiaLing
chia-ling.hou@intel.com
Gerrit-MessageType: comment