Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51379 )
Change subject: drivers/generic/alc1015: Fix missing _DSD and correct property name ......................................................................
drivers/generic/alc1015: Fix missing _DSD and correct property name
Missing acpi_dp_write and correct the name from sdb to sdb-gpios for driver.
BUG=b:177971830 TEST: ALC1015P driver can get sdb-gpio properly.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I2728a7dad695d5c97e85c5d86b1effea1595da65 Reviewed-on: https://review.coreboot.org/c/coreboot/+/51379 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/generic/alc1015/alc1015.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/drivers/generic/alc1015/alc1015.c b/src/drivers/generic/alc1015/alc1015.c index afb9b11..f698b5f 100644 --- a/src/drivers/generic/alc1015/alc1015.c +++ b/src/drivers/generic/alc1015/alc1015.c @@ -40,7 +40,8 @@ /* This points to the first pin in the first gpio entry in _CRS */ path = acpi_device_path(dev); dp = acpi_dp_new_table("_DSD"); - acpi_dp_add_gpio(dp, "sdb", path, 0, 0, config->sdb.active_low); + acpi_dp_add_gpio(dp, "sdb-gpios", path, 0, 0, config->sdb.active_low); + acpi_dp_write(dp);
acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */