Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81445?usp=email )
Change subject: mb/google/nissa/var/glassway: Set VccIn Aux Imon IccMax to 25 A
......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81445/comment/a66003cd_a6254fec :
PS6, Line 9: MBVR
For FIVR design, the VccInAuxImonIccImax should be 27A, for MBVR design VccInAuxImonIccImax should b […]
Done
https://review.coreboot.org/c/coreboot/+/81445/comment/52419006_0dd06286 :
PS6, Line 9: Iccmax of VccIn_Aux is 25A with MBVR design.
Intel FSP ADL default 27A
Done
File src/mainboard/google/brya/variants/glassway/ramstage.c:
https://review.coreboot.org/c/coreboot/+/81445/comment/92a61314_b75636ba :
PS6, Line 7: //
One space?
Done
https://review.coreboot.org/c/coreboot/+/81445/comment/da6c23a7_349c2d6a :
PS6, Line 7: 25*4 For ADL-N
25 * 4 for ADL-N
Done
https://review.coreboot.org/c/coreboot/+/81445/comment/34f98e2c_ca076927 :
PS6, Line 10:
build bot error: adding a line without newline at end of file
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81445?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I105dc9df53c624fd7fc697408a1097e023a3cd68
Gerrit-Change-Number: 81445
Gerrit-PatchSet: 8
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 28 Mar 2024 01:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment