Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39504 )
Change subject: util/inteltool: ahci: rework AHCI
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39504/4/util/inteltool/ahci.c
File util/inteltool/ahci.c:
https://review.coreboot.org/c/coreboot/+/39504/4/util/inteltool/ahci.c@71
PS4, Line 71: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_SATA:
iirc coverity and maybe even gcc want a comment here that the fall-through is intended. […]
I don't think they consider fallthrough when there's no code between case statements.
https://review.coreboot.org/c/coreboot/+/39504/4/util/inteltool/ahci.c@82
PS4, Line 82: ahci_registers_size
Why is this renamed, but "mmio" is not?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37116f8e269d0376e147dd6de7365c45ac90bda0
Gerrit-Change-Number: 39504
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 21:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment