Change in coreboot[master]: soc/intel/cannonlake: Make `acpi_create_gnvs()` static

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42199 )

Change subject: soc/intel/cannonlake: Make `acpi_create_gnvs()` static
......................................................................

soc/intel/cannonlake: Make `acpi_create_gnvs()` static

The function `acpi_create_gnvs()` is only used in this translation unit,
so make it `static`. This unifies it with the Skylake version
`src/soc/intel/skylake/acpi.c`.

Change-Id: I8f817aa46c75332ec5a5fa77e8772ae0f0e3a366
Signed-off-by: Paul Menzel 
---
M src/soc/intel/cannonlake/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42199/1

diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c
index 12758e1..886cba2 100644
--- a/src/soc/intel/cannonlake/acpi.c
+++ b/src/soc/intel/cannonlake/acpi.c
@@ -182,7 +182,7 @@
    return read32((void *)pmc_bar + IRQ_REG);
 }

-void acpi_create_gnvs(struct global_nvs_t *gnvs)
+static void acpi_create_gnvs(struct global_nvs_t *gnvs)
 {
    const struct soc_intel_cannonlake_config *config;
    config = config_of_soc();

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42199 )

Change subject: soc/intel/cannonlake: Make `acpi_create_gnvs()` static
......................................................................

Patch Set 1:

This will require more work.

Change in coreboot[master]: soc/intel: Move `acpi_create_gnvs()` to common code

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42199 )

Change subject: soc/intel: Move `acpi_create_gnvs()` to common code
......................................................................

Patch Set 21:

This change is ready for review.

Change in coreboot[master]: soc/intel: Move `acpi_create_gnvs()` to common code

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Paul Menzel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42199 )

Change subject: soc/intel: Move `acpi_create_gnvs()` to common code
......................................................................

Patch Set 21:

(1 comment)

Patchset:

PS21: 
abandon?

Change in coreboot[master]: soc/intel: Move `acpi_create_gnvs()` to common code

[Paul Menzel (Code Review)]

Paul Menzel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42199 )

Change subject: soc/intel: Move `acpi_create_gnvs()` to common code
......................................................................

Abandoned

Superseded by Kyösti’s GNVS work