Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29816 )
Change subject: mainboard/lenovo/t530: Improve configuration ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/29816/2/src/mainboard/lenovo/t530/Kconfig File src/mainboard/lenovo/t530/Kconfig:
https://review.coreboot.org/#/c/29816/2/src/mainboard/lenovo/t530/Kconfig@41 PS2, Line 41: 0x2a
Would be great to make cmos. […]
so basically move it to mainboard/lenovo?
https://review.coreboot.org/#/c/29816/2/src/mainboard/lenovo/t530/Kconfig@95 PS2, Line 95: config CBFS_SIZE : hex : default 0x001d9000 if VBOOT : default 0x0069b800
Is this even used when using an FMDFILE? I thought it was only used to generate a default FMD?
AFAIK it should be used
-
Philipp Deppenwiese (Code Review)