Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55261 )
Change subject: cpu/x86/lapic: Split virtual_wire_mode_init()
......................................................................
Patch Set 14:
(1 comment)
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/55261/comment/39989154_63c74536
PS13, Line 67: /* Enable the local APIC */
: if (need_lapic_init())
: enable_lapic();
: else if (!CONFIG(UDELAY_LAPIC))
: disable_lapic();
:
: /* This programming is for PIC mode i8259 interrupts to be delivered to CPU
: while LAPIC is enabled. */
: if (need_lapic_init())
: lapic_virtual_wire_mode_init();
Fixing the ExtINT setup for APs was brought up because on AMD platforms some […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5e37c1a0a91fa4e9542141aa74f1c1876fee94e
Gerrit-Change-Number: 55261
Gerrit-PatchSet: 14
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 15 Oct 2021 12:55:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment