Attention is currently required from: CoolStar, Eric Lai, Martin L Roth, Matt DeVillier, Matt DeVillier, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email )
Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/77628/comment/b3498be9_7431c88f :
PS4, Line 255: header->VbiosContent[VFCT_VBIOS_CHECKSUM_OFFSET] = 0;
it's zeroed out first any time it's being re-calculated. […]
when a struct is written from scratch, it gets memset to 0, so in those cases there's no need to set the checksum field to 0 a second time. here, we take an existing data structure, but need to fix up the checksum, so we need to set that field to 0 before calculating the checksum and putting that checksum in place. maybe add a comment about this?
write_le8 isn't needed, since VbiosContent is a byte array, so we can just access that array element
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77628?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I809f87865fd2a25fb106444574b619746aec068d
Gerrit-Change-Number: 77628
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 05 Sep 2023 17:58:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment