Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75555?usp=email )
Change subject: mb/google/rex: Update GPIO PAD IO Standby State ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75555/comment/27be73d3_18a34640 : PS3, Line 9: Type-c
Type-C
I will change
Patchset:
PS3:
we need to apply this on all other variants as well ?
yes, should I add changes for screebo to this patch?
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/75555/comment/94428948_90e1df1b : PS3, Line 19: PAD_CFG_NF_IOSSTATE(GPP_A00, UP_20K, DEEP, NF1, IGNORE),
let me understand the problem, was the issue due to #1 or #2 below or for both ? […]
It was not #1, it was being programmed as NF1.
FSP was modifying the IO Standby State to PAD_CFG1_IOSSTATE_IGNORE before FSP started skipping GpioConfigureIoStandbyState. Now that we are skipping in FSP, coreboot is setting IO Standby State to PAD_CFG1_IOSSTATE_TxLASTRxE, and seems this caused the keyboard / Type-C issues.
"wondering why can't we configure as below or even adding LOCK" PAD_CFG_NF sets PAD_CFG1_IOSSTATE_TxLASTRxE, instead of what we need which is PAD_CFG1_IOSSTATE_IGNORE
-
Bora Guvendik (Code Review)