Attention is currently required from: Nico Huber, Tim Wawrzynczak. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49414 )
Change subject: mb/up/squared: do LPC/eSPI pad configuration at board-level ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/up/squared/bootblock.c:
https://review.coreboot.org/c/coreboot/+/49414/comment/6dfed645_f45688d7 PS1, Line 6: #include "gpio.h"
This includes the whole big `gpio_table` just to garbage collect it […]
If I didn't miss anything, there's not a single board doing it like that, so I wouldn't start inconsistency here.
I would move it to a separate file `early_gpio.h`, like some other boards already do. Same for the changes, where applicable.
-
Michael Niewöhner (Code Review)