Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46887 )
Change subject: soc/intel/broadwell/pch/acpi.c: Remove unnecessary variable ......................................................................
soc/intel/broadwell/pch/acpi.c: Remove unnecessary variable
Tested with BUILD_TIMELESS=1, Google Buddy remains identical.
Change-Id: Iba2678ef7a4696356f9c59a0560ced07e03fda1c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pch/acpi.c 1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46887/1
diff --git a/src/soc/intel/broadwell/pch/acpi.c b/src/soc/intel/broadwell/pch/acpi.c index f45aafc..14aa9ce 100644 --- a/src/soc/intel/broadwell/pch/acpi.c +++ b/src/soc/intel/broadwell/pch/acpi.c @@ -11,7 +11,6 @@ unsigned long acpi_fill_madt(unsigned long current) { int sci = acpi_sci_irq(); - acpi_madt_irqoverride_t *irqovr; uint16_t flags = MP_IRQ_TRIGGER_LEVEL;
/* Local APICs */ @@ -21,8 +20,7 @@ current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, 2, IO_APIC_ADDR, 0);
/* INT_SRC_OVR */ - irqovr = (void *)current; - current += acpi_create_madt_irqoverride(irqovr, 0, 0, 2, 0); + current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, 0, 0, 2, 0);
if (sci >= 20) flags |= MP_IRQ_POLARITY_LOW; @@ -30,8 +28,8 @@ flags |= MP_IRQ_POLARITY_HIGH;
/* SCI */ - irqovr = (void *)current; - current += acpi_create_madt_irqoverride(irqovr, 0, sci, sci, flags); + current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *) + current, 0, sci, sci, flags);
return current; }
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46887
to look at the new patch set (#7).
Change subject: soc/intel/broadwell/pch/acpi.c: Remove unnecessary variable ......................................................................
soc/intel/broadwell/pch/acpi.c: Remove unnecessary variable
Tested with BUILD_TIMELESS=1, Google Buddy remains identical.
Change-Id: Iba2678ef7a4696356f9c59a0560ced07e03fda1c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pch/acpi.c 1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46887/7
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46887 )
Change subject: soc/intel/broadwell/pch/acpi.c: Remove unnecessary variable ......................................................................
Abandoned
File gets deleted anyway
-
Angel Pons (Code Review)