Attention is currently required from: Furquan Shaikh, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50857 )
Change subject: sb/intel/common: Swap callbacks in intel_acpi_gen_def_acpi_pirq
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/common/acpi_pirq_gen.c:
https://review.coreboot.org/c/coreboot/+/50857/comment/98692703_7b6e6a74
PS3, Line 33: pirq - PIRQ_A
We are mixing up semantics here. […]
That's a good read there, very true, APIC does not use the PIR on SKL+. I liked your suggestion of the different acpigen_ functions, that makes this very clear. I will also add some more comments about how PIR maps PIRQs A-H to IRQ 16-23, and about the newer platforms supporting bypassing PIR to directly connect to IRQs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica420a3d12fd1d64c8fe6e4b326fd779b3f10868
Gerrit-Change-Number: 50857
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 25 Feb 2021 22:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment