Change in coreboot[master]: sb/intel/common: Swap callbacks in intel_acpi_gen_def_acpi_pirq
Attention is currently required from: Furquan Shaikh, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50857 )
Change subject: sb/intel/common: Swap callbacks in intel_acpi_gen_def_acpi_pirq ......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/common/acpi_pirq_gen.c:
https://review.coreboot.org/c/coreboot/+/50857/comment/98692703_7b6e6a74 PS3, Line 33: pirq - PIRQ_A
We are mixing up semantics here. […]
That's a good read there, very true, APIC does not use the PIR on SKL+. I liked your suggestion of the different acpigen_ functions, that makes this very clear. I will also add some more comments about how PIR maps PIRQs A-H to IRQ 16-23, and about the newer platforms supporting bypassing PIR to directly connect to IRQs.
-
Tim Wawrzynczak (Code Review)