Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33852
Change subject: util/cbmem: Make internal functions static ......................................................................
util/cbmem: Make internal functions static
These functions are only used in cbmem, so they can be made static.
Change-Id: I21f7d7c21064a8ae951e6d96b28c2ddcf52c0006 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/cbmem/cbmem.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/33852/1
diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index 9a443a8..914effa 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -521,7 +521,7 @@ debug("Timestamp tick frequency: %ld MHz\n", tick_freq_mhz); }
-u64 arch_convert_raw_ts_entry(u64 ts) +static u64 arch_convert_raw_ts_entry(u64 ts) { return ts / tick_freq_mhz; } @@ -569,7 +569,7 @@ return step_time; }
-uint64_t timestamp_print_entry(uint32_t id, uint64_t stamp, uint64_t prev_stamp) +static uint64_t timestamp_print_entry(uint32_t id, uint64_t stamp, uint64_t prev_stamp) { const char *name; uint64_t step_time; @@ -866,7 +866,7 @@ hexdump(unpack_lb64(cbmem.start), unpack_lb64(cbmem.size)); }
-void rawdump(uint64_t base, uint64_t size) +static void rawdump(uint64_t base, uint64_t size) { const uint8_t *m; struct mapping dump_mapping; @@ -927,7 +927,7 @@ static const struct cbmem_id_to_name cbmem_ids[] = { CBMEM_ID_TO_NAME_TABLE };
#define MAX_STAGEx 10 -void cbmem_print_entry(int n, uint32_t id, uint64_t base, uint64_t size) +static void cbmem_print_entry(int n, uint32_t id, uint64_t base, uint64_t size) { const char *name; char stage_x[20];
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33852 )
Change subject: util/cbmem: Make internal functions static ......................................................................
Patch Set 1: Code-Review+1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33852 )
Change subject: util/cbmem: Make internal functions static ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33852 )
Change subject: util/cbmem: Make internal functions static ......................................................................
util/cbmem: Make internal functions static
These functions are only used in cbmem, so they can be made static.
Change-Id: I21f7d7c21064a8ae951e6d96b28c2ddcf52c0006 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33852 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Martin Roth martinroth@google.com --- M util/cbmem/cbmem.c 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index 563bcbe..ca6a2f4 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -521,7 +521,7 @@ debug("Timestamp tick frequency: %ld MHz\n", tick_freq_mhz); }
-u64 arch_convert_raw_ts_entry(u64 ts) +static u64 arch_convert_raw_ts_entry(u64 ts) { return ts / tick_freq_mhz; } @@ -569,7 +569,7 @@ return step_time; }
-uint64_t timestamp_print_entry(uint32_t id, uint64_t stamp, uint64_t prev_stamp) +static uint64_t timestamp_print_entry(uint32_t id, uint64_t stamp, uint64_t prev_stamp) { const char *name; uint64_t step_time; @@ -868,7 +868,7 @@ hexdump(unpack_lb64(cbmem.start), unpack_lb64(cbmem.size)); }
-void rawdump(uint64_t base, uint64_t size) +static void rawdump(uint64_t base, uint64_t size) { const uint8_t *m; struct mapping dump_mapping; @@ -929,7 +929,7 @@ static const struct cbmem_id_to_name cbmem_ids[] = { CBMEM_ID_TO_NAME_TABLE };
#define MAX_STAGEx 10 -void cbmem_print_entry(int n, uint32_t id, uint64_t base, uint64_t size) +static void cbmem_print_entry(int n, uint32_t id, uint64_t base, uint64_t size) { const char *name; char stage_x[20];