Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33853
Change subject: util/cbmem: Enable -Wmissing-prototypes ......................................................................
util/cbmem: Enable -Wmissing-prototypes
Change-Id: Ia8482dc9b6ad800826152c2d3e9813190b0b574e Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/cbmem/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33853/1
diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index e7318a1..485955b 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -19,7 +19,7 @@ INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 -CFLAGS += -Wall -Wextra -Werror +CFLAGS += -Wall -Wextra -Wmissing-prototypes -Werror CPPFLAGS += -I . -I $(ROOT)/commonlib/include CPPFLAGS += -include ../../src/commonlib/include/commonlib/compiler.h
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33853 )
Change subject: util/cbmem: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33853 )
Change subject: util/cbmem: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33853 )
Change subject: util/cbmem: Enable -Wmissing-prototypes ......................................................................
util/cbmem: Enable -Wmissing-prototypes
Change-Id: Ia8482dc9b6ad800826152c2d3e9813190b0b574e Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33853 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Martin Roth martinroth@google.com --- M util/cbmem/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index e7318a1..485955b 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -19,7 +19,7 @@ INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 -CFLAGS += -Wall -Wextra -Werror +CFLAGS += -Wall -Wextra -Wmissing-prototypes -Werror CPPFLAGS += -I . -I $(ROOT)/commonlib/include CPPFLAGS += -include ../../src/commonlib/include/commonlib/compiler.h
-
Jacob Garber (Code Review) -
Martin Roth (Code Review)
-
Paul Menzel (Code Review)