Attention is currently required from: Intel coreboot Reviewers, Name of user not set #1005756, Patrick Rudolph.
Paul Menzel has posted comments on this change by Name of user not set #1005756. ( https://review.coreboot.org/c/coreboot/+/86562?usp=email )
Change subject: src/cpu/intel/car/romstage.c: Refactor stack guard code in romstage
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86562/comment/fb185b5d_e956cdde?usp... :
PS2, Line 7: src/cpu/intel/car/romstage.c
I suggest: cpu/intel/car/romstage
https://review.coreboot.org/c/coreboot/+/86562/comment/794148bb_b0fad66f?usp... :
PS2, Line 9: Refactor stack guard code in romstage.
Madybe more specific: Factor out stack_guard_set() and …() for improving readability.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86562?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I754e422c0023cd7824dd6109f031239756acff4b
Gerrit-Change-Number: 86562
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1005756
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Name of user not set #1005756
Gerrit-Comment-Date: Sun, 23 Feb 2025 13:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No