greg@unrelenting.technology has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35866 )
Change subject: ec/google/chromeec: fix format security warning ......................................................................
ec/google/chromeec: fix format security warning
Change-Id: I7a7bcb56523d595e8d4f32849aac53d66d416a12 Signed-off-by: Greg V greg@unrelenting.technology --- M src/ec/google/chromeec/ec.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/35866/1
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 1b0f7ee..7c294b6 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1063,7 +1063,7 @@ if ((cmd_resp.ec_reset_flags & (1 << flag)) != 0) { if (flag_count) printk(BIOS_DEBUG, " | "); - printk(BIOS_DEBUG, reset_flag_strings[flag]); + printk(BIOS_DEBUG, "%s", reset_flag_strings[flag]); flag_count++; } }
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35866 )
Change subject: ec/google/chromeec: fix format security warning ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35866 )
Change subject: ec/google/chromeec: fix format security warning ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35866 )
Change subject: ec/google/chromeec: fix format security warning ......................................................................
ec/google/chromeec: fix format security warning
Change-Id: I7a7bcb56523d595e8d4f32849aac53d66d416a12 Signed-off-by: Greg V greg@unrelenting.technology Reviewed-on: https://review.coreboot.org/c/coreboot/+/35866 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/chromeec/ec.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 1b0f7ee..7c294b6 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1063,7 +1063,7 @@ if ((cmd_resp.ec_reset_flags & (1 << flag)) != 0) { if (flag_count) printk(BIOS_DEBUG, " | "); - printk(BIOS_DEBUG, reset_flag_strings[flag]); + printk(BIOS_DEBUG, "%s", reset_flag_strings[flag]); flag_count++; } }