Attention is currently required from: Jason Glenesk, Martin L Roth, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73168 )
Change subject: soc/amd/common/block/apob_cache: Add support for RECOVERY_MRC_CACHE
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/common/block/apob/apob_cache.c:
https://review.coreboot.org/c/coreboot/+/73168/comment/904dd295_47033d11
PS1, Line 93: int
out of scope for this patch, but would be good to use enum cb_err here in a follow-up
https://review.coreboot.org/c/coreboot/+/73168/comment/d78807d9_66a5f97f
PS1, Line 104: int
same enum cb_err comment applies here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93f357e407c98b6e5fca495f4f779fad54a3430f
Gerrit-Change-Number: 73168
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 19:11:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment