[S] Change in coreboot[master]: mb/google/rex: Add fingerprint SPI - coreboot-gerrit

9 Nov 2022


      Attention is currently required from: Subrata Banik, Kapil Porwal, Eric Lai.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI
......................................................................
Patch Set 19:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/66992/comment/c2e073f9_148f3199 
PS14, Line 439: 	/* GPP_B11 : [] ==> EN_FP_PWR */
              : 	PAD_CFG_GPO(GPP_B11, 0, DEEP),
...
To be complete, I'd like us to measure (with oscilloscope) and record the timings so we can referenc […]
Will follow up on that comment and post the measurement later.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/66992
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e6be24e72a8232ae2c958a01cf8ea9a272d7365
Gerrit-Change-Number: 66992
Gerrit-PatchSet: 19
Gerrit-Owner: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 22:28:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli taruntuli@google.com
Comment-In-Reply-To: Eran Mitrani mitrani@google.com
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment