Attention is currently required from: Artur Kowalski, Michał Kopeć, Krystian Hebel, Elyes Haouas, Piotr Król.
Kacper Stojek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72407 )
Change subject: mainboard/protectli/vault_ehl: Add initial structure ......................................................................
Patch Set 15:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72407/comment/41a7cee8_1f67cfb6 PS12, Line 9: This patch base code for the Protectli VP2420
Please add verb to make a sentence from it.
Done
File Documentation/mainboard/protectli/vp2420.md:
https://review.coreboot.org/c/coreboot/+/72407/comment/9ffc22e9_008d2975 PS12, Line 27: socketed SOIC-8 chip. : This chip is located on the top side of the case (the lid side). One has to : remove 4 top cover screws and lift up the lid. The flash chip is soldered
Should be soldered. […]
Done
File configs/config.protectli_vp2420:
https://review.coreboot.org/c/coreboot/+/72407/comment/9272a5e4_bd89bfd7 PS12, Line 1: CONFIG_LOCALVERSION="4.13"
Remove this.
Done
File src/mainboard/protectli/vault_ehl/Kconfig:
https://review.coreboot.org/c/coreboot/+/72407/comment/fdd32e3f_f3e56067 PS12, Line 39: # select VBOOT_NO_TPM
Why is this line commented out? Can it be removed instead?
Leftover from editing the configs, removed.
File src/mainboard/protectli/vault_ehl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/72407/comment/ef3bcd22_49e8d904 PS12, Line 96: device pci 00.0 on end # Host Bridge
Different indentation than other lines (no tab between `on` and `end`).
Done
File src/mainboard/protectli/vault_ehl/die.c:
https://review.coreboot.org/c/coreboot/+/72407/comment/246c0a00_0857b961 PS12, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Mainbaord may use different GPIOs than SATA LEDs. […]
Resolving this then.
-
Kacper Stojek (Code Review)