Attention is currently required from: Christian Walter, Sean Rhodes.
Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/74743?usp=email )
Change subject: mb/starlabs/starbook: Put options in CFR cbtable
......................................................................
Patch Set 35:
(1 comment)
File src/mainboard/starlabs/starbook/cfr.c:
https://review.coreboot.org/c/coreboot/+/74743/comment/04729363_af1ce108?usp... :
PS35, Line 380: void lb_board(struct lb_header *header)
: {
: char *current = (char *)lb_new_record(header);
: struct lb_cfr *cfr_root = (struct lb_cfr *)current;
:
: cfr_write_setup_menu(cfr_root, sm_root);
: }
:
looks fine to me?
I had to edit and save the message like half a dozen times before it'd show up without any missing newlines
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74743?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6
Gerrit-Change-Number: 74743
Gerrit-PatchSet: 35
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Sat, 11 Jan 2025 17:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com