Attention is currently required from: Nico Huber, Tim Wawrzynczak. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49412 )
Change subject: mb/google/reef: do LPC/eSPI pad configuration at board-level ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
Please add comments then that it is unconfirmed whether the redundancy is […]
Done
File src/mainboard/google/reef/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/49412/comment/50c7e50e_03309ab4 PS1, Line 353: I2S1
It's not in native function mode, so what value does this comment provide?
probably a case of "it was late" ;) added a newlines like done in the main table above
File src/mainboard/google/reef/variants/coral/gpio.c:
https://review.coreboot.org/c/coreboot/+/49412/comment/a3d09927_e6cf537d PS1, Line 354: I2S1
It's not in native function mode, so what value does this comment provide?
same as baseboard