Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/72962
to review the following change.
Change subject: mb/amd/birman&mayan: Shrink the size of EC region to 1K ......................................................................
mb/amd/birman&mayan: Shrink the size of EC region to 1K
The EC region is EC signature, which only needs few bytes.
amdfw.rom is at offset 128K. The COREBOOT region needs some extra bytes for CBFS module head. So it can not be at exact 128K.
For compatibility, the chromeos.fmd is also changed.
Change-Id: I0b51a4718475c541df2935d25fdbe3d65bc49f68 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/mainboard/amd/birman/board.fmd M src/mainboard/amd/birman/chromeos.fmd M src/mainboard/amd/mayan/board.fmd M src/mainboard/amd/mayan/chromeos.fmd 4 files changed, 21 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/72962/1
diff --git a/src/mainboard/amd/birman/board.fmd b/src/mainboard/amd/birman/board.fmd index 6c6ad92..aaa2ba6 100644 --- a/src/mainboard/amd/birman/board.fmd +++ b/src/mainboard/amd/birman/board.fmd @@ -1,6 +1,6 @@ FLASH@0xFF000000 16M { BIOS { - EC 4K + EC 1K RW_MRC_CACHE 120K FMAP 4K COREBOOT(CBFS) diff --git a/src/mainboard/amd/birman/chromeos.fmd b/src/mainboard/amd/birman/chromeos.fmd index 538dfbd..a8db6a5 100644 --- a/src/mainboard/amd/birman/chromeos.fmd +++ b/src/mainboard/amd/birman/chromeos.fmd @@ -1,7 +1,7 @@ FLASH@0xFF000000 16M { SI_BIOS { WP_RO 8M { - EC 4K + EC 1K RO_VPD(PRESERVE) 16K RO_SECTION { FMAP 2K diff --git a/src/mainboard/amd/mayan/board.fmd b/src/mainboard/amd/mayan/board.fmd index 6c6ad92..aaa2ba6 100644 --- a/src/mainboard/amd/mayan/board.fmd +++ b/src/mainboard/amd/mayan/board.fmd @@ -1,6 +1,6 @@ FLASH@0xFF000000 16M { BIOS { - EC 4K + EC 1K RW_MRC_CACHE 120K FMAP 4K COREBOOT(CBFS) diff --git a/src/mainboard/amd/mayan/chromeos.fmd b/src/mainboard/amd/mayan/chromeos.fmd index 538dfbd..a8db6a5 100644 --- a/src/mainboard/amd/mayan/chromeos.fmd +++ b/src/mainboard/amd/mayan/chromeos.fmd @@ -1,7 +1,7 @@ FLASH@0xFF000000 16M { SI_BIOS { WP_RO 8M { - EC 4K + EC 1K RO_VPD(PRESERVE) 16K RO_SECTION { FMAP 2K