Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40414 )
Change subject: lib/spd_bin: add get_spd_sn function
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40414/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/40414/4/src/soc/intel/common/block/...
PS4, Line 85: return sn == 0x00000000, if addr is 0x0.
: return sn == 0xffffffff, if dimm is not present. */
In new patchset, it will return a CB_ERR and sn will become u32 pointer. […]
Sounds good!
https://review.coreboot.org/c/coreboot/+/40414/4/src/soc/intel/common/block/...
PS4, Line 87: u8 *sn
In new patchset, it will return a CB_ERR and sn will become u32 pointer. […]
Ack
https://review.coreboot.org/c/coreboot/+/40414/4/src/soc/intel/common/block/...
PS4, Line 92: /* smbus will return 0xff if addr is zero */
: if (addr == 0x00) {
: memset(sn, 0, SPD_SN_LEN);
: return;
: }
As Eric mentioned, I saw return value -1(0xffffffff) when I removed the DIMM. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I406bba7cc56debbd9851d430f069e4fb96ec937c
Gerrit-Change-Number: 40414
Gerrit-PatchSet: 6
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 19:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Chen
jamie.chen@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment