3 comments:
File src/soc/intel/common/block/smbus/smbuslib.c:
return sn == 0x00000000, if addr is 0x0.
return sn == 0xffffffff, if dimm is not present. */
In new patchset, it will return a CB_ERR and sn will become u32 pointer. […]
Sounds good!
Patch Set #4, Line 87: u8 *sn
In new patchset, it will return a CB_ERR and sn will become u32 pointer. […]
Ack
/* smbus will return 0xff if addr is zero */
if (addr == 0x00) {
memset(sn, 0, SPD_SN_LEN);
return;
}
As Eric mentioned, I saw return value -1(0xffffffff) when I removed the DIMM. […]
Ack
To view, visit change 40414. To unsubscribe, or for help writing mail filters, visit settings.