Vijay P Hiremath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37870/16/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/37870/16/src/soc/intel/tigerlake/ea... PS16, Line 155: mux_flags & USB_PD_MUX_USB_ENABLED please change all the below items to bool !!(mux_data.usb = mux_flags & USB_PD_MUX_USB_ENABLED)
https://review.coreboot.org/c/coreboot/+/37870/16/src/soc/intel/tigerlake/ea... PS16, Line 158: mux_data.polarity = mux_flags & USB_PD_MUX_POLARITY_INVERTED;
i'm a bit confused about the polarity and muxing policy. […]
This is applicable to Virtual muxes only (SOC has the mux). We should not use this file for external mux configurations as it is handled by the EC.
-
Vijay P Hiremath (Code Review)