Change in coreboot[master]: mb/zork/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Lucas Chen (Code Review)]

Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: mb/zork/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

mb/zork/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

The gpio90 EN_PWR_TOUCHSCREEN had been set to PAD_GPO(GPIO_90, LOW), but
addtional PAD_NC(GPIO_90) cause enable fail. remove it for issue fixed.

BUG=b:168580357
TEST=Check Touchscreen function work

Signed-off-by: Lucas Chen 
Change-Id: Id94dd63ba51759cebaf17779a5e659dbe0f1807f
---
M src/mainboard/google/zork/variants/ezkinil/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/45415/1

diff --git a/src/mainboard/google/zork/variants/ezkinil/gpio.c b/src/mainboard/google/zork/variants/ezkinil/gpio.c
index 108a134..0ec1ab23 100644
--- a/src/mainboard/google/zork/variants/ezkinil/gpio.c
+++ b/src/mainboard/google/zork/variants/ezkinil/gpio.c
@@ -68,8 +68,6 @@
    PAD_NC(GPIO_69),
    /* EN_DEV_BEEP_L */
    PAD_GPO(GPIO_89, HIGH),
-	/* TP */
-	PAD_NC(GPIO_90),
    /* USI_RESET */
    PAD_GPO(GPIO_140, HIGH),
 };

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: mb/zork/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 1: Code-Review+1

[Eric Peers (Code Review)]

Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: mb/zork/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 1:

need BRANCH=Zork?

Do you need to bump the version number on your board in CBI to correctly test the rework instead of making this code change? (0x3)?

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: mb/zork/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 1:
> Patch Set 1:
>
> need BRANCH=Zork?
>
> Do you need to bump the version number on your board in CBI to correctly test the rework instead of making this code change? (0x3)?

Actually, looks like the latest revision of hardware is supposed to use 3. And this is the board version that supports v3.6+ schematics: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: mb/zork/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 1: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG@7 
PS1, Line 7: ezkinil
zork/var/ezkinil:

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG@12 
PS1, Line 12: BUG=b:168580357
As Eric mentioned:

BRANCH=zork

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Lucas Chen (Code Review)]

Hello build bot (Jenkins), David Wu, Furquan Shaikh, Bhanu Prakash Maiya, Vincent Wang, Josie Nordrum, Rob Barnes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45415

to look at the new patch set (#2).

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

The gpio90 EN_PWR_TOUCHSCREEN had been set to PAD_GPO(GPIO_90, LOW), but
addtional PAD_NC(GPIO_90) cause enable fail. remove it for issue fixed.

BRANCH=zork
BUG=b:168580357
TEST=Check Touchscreen function work

Signed-off-by: Lucas Chen 
Change-Id: Id94dd63ba51759cebaf17779a5e659dbe0f1807f
---
M src/mainboard/google/zork/variants/ezkinil/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/45415/2

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG@7 
PS1, Line 7: ezkinil
> zork/var/ezkinil:

Done.

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG@12 
PS1, Line 12: BUG=b:168580357
> As Eric mentioned: […]

Done.

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 2: Code-Review+2

I'll give this my +2 in case someone wants to merge it early, but I think the commit message should be updated further to meet the guidelines for getting the patch merge on an emergency basis with 3 +2 votes.

Here's what the guideline says:
"A change can go in without the wait period if its purpose is to fix a recently-introduced issue (build, boot or OS-level compatibility, not necessarily identified by coreboot.org facilities). Its commit message has to explain what change introduced the problem and the nature of the problem so that the emergency need becomes apparent. The change itself should be as limited in scope and impact as possible to make it simple to assess the impact. Such a change can be merged early with 3 Code-Review+2. For emergency fixes that affect a single project (SoC, mainboard, …) it’s strongly recommended to get a review by somebody not involved with that project to ensure that the documentation of the issue is clear enough."

The recently introduced issue is the hardware change.
The fix is obviously very limited in scope, being contained to a single mainboard within the zork project.

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 2:

Here's a suggested commit message for merging early:

zork/var/ezkinil: Fix Touchscreen for schematic v3.6x

GPIO 90 (EN_PWR_TOUCHSCREEN) is set to PAD_GPO(GPIO_90, LOW), in
the trembyle baseboard code, but was overridden to PAD_NC(GPIO_90)
in the ezkinil-specific gpio configuration. This override causes
the touchscreen enable to fail. 
Removing the PAD_NC() override code fixes the issue.

This is urgently needed to get an official build for the reworked
board and to unblock the production of the next boards.  The
recently-introduced change that requires the fix is the new
schematic.

Obviously this fix is very limited in scope, affecting just the
ezkinil mainboard.

BRANCH=zork
BUG=b:168580357
TEST=Check Touchscreen function work

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG@7 
PS1, Line 7: ezkinil
> Done.

Done

https://review.coreboot.org/c/coreboot/+/45415/1//COMMIT_MSG@12 
PS1, Line 12: BUG=b:168580357
> Done.

Done

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[Aaron Durbin (Code Review)]

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

The gpio90 EN_PWR_TOUCHSCREEN had been set to PAD_GPO(GPIO_90, LOW), but
addtional PAD_NC(GPIO_90) cause enable fail. remove it for issue fixed.

BRANCH=zork
BUG=b:168580357
TEST=Check Touchscreen function work

Signed-off-by: Lucas Chen 
Change-Id: Id94dd63ba51759cebaf17779a5e659dbe0f1807f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45415
Reviewed-by: Martin Roth 
Reviewed-by: Aaron Durbin 
Reviewed-by: Furquan Shaikh 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/zork/variants/ezkinil/gpio.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Aaron Durbin: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved
  Lucas Chen: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/zork/variants/ezkinil/gpio.c b/src/mainboard/google/zork/variants/ezkinil/gpio.c
index 108a134..0ec1ab23 100644
--- a/src/mainboard/google/zork/variants/ezkinil/gpio.c
+++ b/src/mainboard/google/zork/variants/ezkinil/gpio.c
@@ -68,8 +68,6 @@
    PAD_NC(GPIO_69),
    /* EN_DEV_BEEP_L */
    PAD_GPO(GPIO_89, HIGH),
-	/* TP */
-	PAD_NC(GPIO_90),
    /* USI_RESET */
    PAD_GPO(GPIO_140, HIGH),
 };

Change in coreboot[master]: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )

Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19497
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19496
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19495
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19494
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19493
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19501
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19500
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19499
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19498

Please note: This test is under development and might not be accurate at all!