Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86278?usp=email )
Change subject: soc/intel/alderlake: Use helper for UX messages ......................................................................
Patch Set 17:
(1 comment)
File src/soc/intel/alderlake/romstage/ux.c:
https://review.coreboot.org/c/coreboot/+/86278/comment/7e93cf9b_87a3a70e?usp... : PS17, Line 11: const char *name
Debug statement will be human-readable/comprehensible with name over id. May be an internal id -> name mapping will address them both.
I don't believe this is *pointless* because although we are using eSOL UX ID as `UX_LOCALE_MSG_MEMORY_TRAINING` bur we are internally re-purposing to render eSOL msg for different use cases:
1. Just MRC update 2. Just CSE update 3. Both MRC and CSE update
https://github.com/coreboot/coreboot/blob/main/src/soc/intel/alderlake/romst...
`ux_inform_user_of_update_operation` API allow callerw to reuse the eSOL feature with index UX_LOCALE_MSG_MEMORY_TRAINING to meet multiple usecases mostlt related to fw updates during memory init. Assume we need to establish `id->name` mapping then it can be only establish between msg_id and locales_name but not with human-readable name like "memory training"/ "CSE update" etc.
the debug msg at line#20 is mainly used for debugging therefore, we may not need lots of optimization about how we would like to use debug string.
-
Subrata Banik (Code Review)