Change in coreboot[master]: [WIP] Nvidia Optimus support for ThinkPads

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 )

Change subject: [WIP] Nvidia Optimus support for ThinkPads
......................................................................

Patch Set 7:

(1 comment)

This change is ready for review.

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28380/7//COMMIT_MSG@29
PS7, Line 29: - nouveau driver unloading (`rmmod` or `modprobe -r`) does not work well: it
> Can you test if it does work without the optimus patch? I could imagine it's related to missing ACPI […]

Actually I discovered that it crashes with Lenovo BIOS too! Here is a dump:

[   42.530328] BUG: unable to handle kernel paging request at ffffc90004507970
[   42.530389] IP: nouveau_backlight_exit+0x24/0x60 [nouveau]
[   42.530392] PGD 62588b067 P4D 62588b067 PUD 62588c067 PMD 621d82067 PTE 0
[   42.530399] Oops: 0000 [#1] SMP PTI
[   42.530402] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat acpi_call(O) xt_conntrack xt_NFLOG xt_policy xt_LOG xt_connlimit nf_conncount xt_limit cifs rndis_host cdc_subset ipheth cdc_acm cdc_ether usbnet mii i2c_dev vboxpci(O) vboxnetadp(O) btusb btrtl btbcm btintel vboxnetflt(O) vboxdrv(O) nouveau(-) iwldvm x86_pkg_temp_thermal iwlwifi coretemp ttm efivarfs fuse
[   42.530439] CPU: 5 PID: 8030 Comm: rmmod Tainted: G           O     4.16.13-gentoo #10
[   42.530441] Hardware name: LENOVO 2463A49/2463A49, BIOS G5ET92WW (2.52 ) 02/27/2013
[   42.530474] RIP: 0010:nouveau_backlight_exit+0x24/0x60 [nouveau]
[   42.530477] RSP: 0018:ffffc900037afd80 EFLAGS: 00010212
[   42.530480] RAX: 0000000000000000 RBX: ffffc90004507960 RCX: 0000000000000004
[   42.530482] RDX: ffffffff00000001 RSI: ffff88061e449210 RDI: ffff88061eee0000
[   42.530485] RBP: ffff88061e4491b8 R08: 0000000000000000 R09: ffffffffa01e34b0
[   42.530487] R10: 0000000000000000 R11: 0000000000000040 R12: ffffffffa02dc730
[   42.530489] R13: ffff88061e448000 R14: ffff880621db8100 R15: 0000000000000000
[   42.530492] FS:  00007f62cb235740(0000) GS:ffff88063e340000(0000) knlGS:0000000000000000
[   42.530494] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   42.530496] CR2: ffffc90004507970 CR3: 000000060448e002 CR4: 00000000001606e0
[   42.530498] Call Trace:
[   42.530532]  nouveau_display_destroy+0x24/0x70 [nouveau]
[   42.530563]  nouveau_drm_unload+0x60/0xe0 [nouveau]
[   42.530571]  drm_dev_unregister+0x37/0xe0
[   42.530576]  drm_put_dev+0x29/0x60
[   42.530605]  nouveau_drm_device_remove+0x42/0x70 [nouveau]
[   42.530611]  pci_device_remove+0x31/0xa0
[   42.530618]  device_release_driver_internal+0x14f/0x220
[   42.530622]  driver_detach+0x2d/0x60
[   42.530626]  bus_remove_driver+0x43/0xa0
[   42.530629]  pci_unregister_driver+0x2f/0x90
[   42.530661]  nouveau_drm_exit+0x15/0xf58 [nouveau]
[   42.530666]  SyS_delete_module+0x193/0x250
[   42.530671]  ? task_work_run+0x2e/0x90
[   42.530675]  do_syscall_64+0x55/0x100
[   42.530682]  entry_SYSCALL_64_after_hwframe+0x3d/0xa2
[   42.530699] RIP: 0033:0x7f62cab9b5e7
[   42.530701] RSP: 002b:00007ffe72e19058 EFLAGS: 00000202 ORIG_RAX: 00000000000000b0
[   42.530704] RAX: ffffffffffffffda RBX: 00007ffe72e190a8 RCX: 00007f62cab9b5e7
[   42.530706] RDX: 000000000000000a RSI: 0000000000000800 RDI: 00005615fc7e3808
[   42.530708] RBP: 00005615fc7e37a0 R08: 00007ffe72e17fd1 R09: 000000000000000a
[   42.530710] R10: 00000000000008b1 R11: 0000000000000202 R12: 00007ffe72e19270
[   42.530712] R13: 00007ffe72e19808 R14: 0000000000000000 R15: 00005615fc7e37a0
[   42.530714] Code: 1f 84 00 00 00 00 00 41 55 41 54 49 c7 c4 30 c7 2d a0 55 53 4c 8b 6f 28 49 8b 9d b8 11 00 00 49 8d ad b8 11 00 00 48 39 eb 74 17 <8b> 73 10 85 f6 78 08 4c 89 e7 e8 9d 5d 9d e1 48 8b 1b 48 39 eb 
[   42.530797] RIP: nouveau_backlight_exit+0x24/0x60 [nouveau] RSP: ffffc900037afd80
[   42.530798] CR2: ffffc90004507970
[   42.530802] ---[ end trace 2dc5a712a9603d67 ]---

And this is with coreboot:

[   66.973310] BUG: unable to handle kernel paging request at ffffc900085e7970
[   66.973362] IP: nouveau_backlight_exit+0x24/0x60 [nouveau]
[   66.973365] PGD 66488b067 P4D 66488b067 PUD 66488c067 PMD 6613b9067 PTE 0
[   66.973377] Oops: 0000 [#1] SMP PTI
[   66.973381] Modules linked in: xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat acpi_call(O) xt_conntrack xt_NFLOG xt_policy xt_LOG xt_connlimit nf_conncount xt_limit cifs rndis_host cdc_subset ipheth cdc_acm cdc_ether usbnet mii i2c_dev iwldvm vboxpci(O) vboxnetadp(O) vboxnetflt(O) btusb btrtl btbcm btintel vboxdrv(O) nouveau(-) x86_pkg_temp_thermal coretemp iwlwifi ttm fuse
[   66.973433] CPU: 1 PID: 7972 Comm: rmmod Tainted: G           O     4.16.13-gentoo #10
[   66.973436] Hardware name: LENOVO 2463A49/2463A49, BIOS CBET4000 4.8-1380-g6a78a29f44 08/30/2018
[   66.973483] RIP: 0010:nouveau_backlight_exit+0x24/0x60 [nouveau]
[   66.973488] RSP: 0018:ffffc90003937d80 EFLAGS: 00010212
[   66.973493] RAX: 0000000000000000 RBX: ffffc900085e7960 RCX: 0000000000000004
[   66.973497] RDX: ffffffff00000001 RSI: ffff88065c379210 RDI: ffff88065c369000
[   66.973501] RBP: ffff88065c3791b8 R08: 0000000000000000 R09: ffffffffa01954b0
[   66.973505] R10: 0000000000000000 R11: 0000000000000040 R12: ffffffffa028e730
[   66.973509] R13: ffff88065c378000 R14: ffff8806608aa900 R15: 0000000000000000
[   66.973515] FS:  00007fe57e96c740(0000) GS:ffff88067d240000(0000) knlGS:0000000000000000
[   66.973519] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   66.973523] CR2: ffffc900085e7970 CR3: 000000065f2fe005 CR4: 00000000001606e0
[   66.973527] Call Trace:
[   66.973576]  nouveau_display_destroy+0x24/0x70 [nouveau]
[   66.973625]  nouveau_drm_unload+0x60/0xe0 [nouveau]
[   66.973638]  drm_dev_unregister+0x37/0xe0
[   66.973646]  drm_put_dev+0x29/0x60
[   66.973689]  nouveau_drm_device_remove+0x42/0x70 [nouveau]
[   66.973698]  pci_device_remove+0x31/0xa0
[   66.973708]  device_release_driver_internal+0x14f/0x220
[   66.973715]  driver_detach+0x2d/0x60
[   66.973721]  bus_remove_driver+0x43/0xa0
[   66.973727]  pci_unregister_driver+0x2f/0x90
[   66.973766]  nouveau_drm_exit+0x15/0xf58 [nouveau]
[   66.973772]  SyS_delete_module+0x193/0x250
[   66.973778]  ? task_work_run+0x2e/0x90
[   66.973782]  do_syscall_64+0x55/0x100
[   66.973790]  entry_SYSCALL_64_after_hwframe+0x3d/0xa2
[   66.973793] RIP: 0033:0x7fe57e2d25e7
[   66.973796] RSP: 002b:00007ffd9df9bb98 EFLAGS: 00000202 ORIG_RAX: 00000000000000b0
[   66.973799] RAX: ffffffffffffffda RBX: 00007ffd9df9bbe8 RCX: 00007fe57e2d25e7
[   66.973802] RDX: 000000000000000a RSI: 0000000000000800 RDI: 0000561bbded3808
[   66.973804] RBP: 0000561bbded37a0 R08: 00007ffd9df9ab11 R09: 000000000000000a
[   66.973806] R10: 00000000000008b1 R11: 0000000000000202 R12: 00007ffd9df9bdb0
[   66.973808] R13: 00007ffd9df9d808 R14: 0000000000000000 R15: 0000561bbded37a0
[   66.973811] Code: 1f 84 00 00 00 00 00 41 55 41 54 49 c7 c4 30 e7 28 a0 55 53 4c 8b 6f 28 49 8b 9d b8 11 00 00 49 8d ad b8 11 00 00 48 39 eb 74 17 <8b> 73 10 85 f6 78 08 4c 89 e7 e8 9d 3d a2 e1 48 8b 1b 48 39 eb 
[   66.973889] RIP: nouveau_backlight_exit+0x24/0x60 [nouveau] RSP: ffffc90003937d80
[   66.973891] CR2: ffffc900085e7970
[   66.973894] ---[ end trace 91d8759a29e86bc6 ]---