Attention is currently required from: Martin Roth, Jonathan Zhang, Christian Walter, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50410 )
Change subject: security/intel/cbnt: Generate KM from Kconfig symbols ......................................................................
Patch Set 16: Code-Review+1
(4 comments)
File src/security/intel/cbnt/Kconfig:
https://review.coreboot.org/c/coreboot/+/50410/comment/8cdf52f3_112947fd PS16, Line 27: bool "KM: use a CBnT config file" Please add `JSON` somewhere in the prompt, so that users know what kind of config file this is.
https://review.coreboot.org/c/coreboot/+/50410/comment/46770e17_9a802774 PS16, Line 40: config INTEL_CBNT_KM_KEY_FILE IMHO, this should remain as close as possible to `config INTEL_CBNT_GENERATE_KM`
https://review.coreboot.org/c/coreboot/+/50410/comment/f21c48a6_8eaf2e0d PS16, Line 71: ENF ?
https://review.coreboot.org/c/coreboot/+/50410/comment/31782f96_711f7aef PS16, Line 74: we nit: I'd use `one` instead of `we`
-
Angel Pons (Code Review)