Attention is currently required from: Bill XIE.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74180 )
Change subject: nb/intel/gm45: Export EDID-reading routine as a function ......................................................................
Patch Set 1:
(1 comment)
File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/c/coreboot/+/74180/comment/116cdc9d_73e916d2 PS1, Line 161: /* : * GTT base is at a 2M offset and is 2M big. If GTT is smaller than 2M : * cycles are simply not decoded which is fine. : */ : pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); : memset(mmio + 2 * MiB, 0, 2 * MiB); : pci_and_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER);
But get_edid_str() may be called elsewhere. Won't PCI_COMMAND_MASTER being kept by GMA be problematic?
A reason more why this function should not touch it. It should return edid string, not clear PCI bits.