Attention is currently required from: Rex-BC Chen.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56204 )
Change subject: soc/mediatek/mt8195: Get DRAM size from DRAM calibration result
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8195/emi.c:
https://review.coreboot.org/c/coreboot/+/56204/comment/2ac810ef_38c7c361
PS1, Line 10: size_t
I think the sdram_size may be called multiple times in ram stage (also rom stage).
Should we change this to
static size_t dram_size = 0;
if (dram_size)
return dram_size;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic34f29d1692b94284b2cf6c5d91d323df736c76f
Gerrit-Change-Number: 56204
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ryan Chuang
ryan.chuang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Jul 2021 02:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment