Change in ...coreboot[master]: src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32565
Change subject: src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig ......................................................................
src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig
The entry for drivers/intel/fsp1_0/Kconfig was added under the chipset menu before addtional FSP versions were added, and the drivers/*/*/Kconfig entry added to support them. This results in the fsp1_0 Kconfig items being duplicated in the Chipset and Generic Drivers menus.
Remove the chipset entry since it's no longer needed.
Test: select FSP 1.0 mainboard (e.g. intel/minnowmax) in menuconfig, observe FSP 1.0 Kconfig entries listed only under Generic Drivers menu.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: If1e78fb9259b1a46d308db829881eb3b3d17cf40 --- M src/Kconfig 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32565/1
diff --git a/src/Kconfig b/src/Kconfig index 90c724e..05875b6 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -370,8 +370,6 @@ comment "Embedded Controllers" source "src/ec/acpi/Kconfig" source "src/ec/*/*/Kconfig" -# FIXME move to vendorcode -source "src/drivers/intel/fsp1_0/Kconfig"
source "src/southbridge/intel/common/firmware/Kconfig" source "src/vendorcode/*/Kconfig"
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32565 )
Change subject: src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32565 )
Change subject: src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32565 )
Change subject: src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig ......................................................................
src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig
The entry for drivers/intel/fsp1_0/Kconfig was added under the chipset menu before addtional FSP versions were added, and the drivers/*/*/Kconfig entry added to support them. This results in the fsp1_0 Kconfig items being duplicated in the Chipset and Generic Drivers menus.
Remove the chipset entry since it's no longer needed.
Test: select FSP 1.0 mainboard (e.g. intel/minnowmax) in menuconfig, observe FSP 1.0 Kconfig entries listed only under Generic Drivers menu.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: If1e78fb9259b1a46d308db829881eb3b3d17cf40 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32565 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/Kconfig 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 90c724e..05875b6 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -370,8 +370,6 @@ comment "Embedded Controllers" source "src/ec/acpi/Kconfig" source "src/ec/*/*/Kconfig" -# FIXME move to vendorcode -source "src/drivers/intel/fsp1_0/Kconfig"
source "src/southbridge/intel/common/firmware/Kconfig" source "src/vendorcode/*/Kconfig"
-
Furquan Shaikh (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)