HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33053
Change subject: crossgcc: Upgrade CMake to 3.14.4 ......................................................................
crossgcc: Upgrade CMake to 3.14.4
Change: "In CMake 3.14.0 through 3.14.3, calling target_link_libraries() to add PRIVATE dependencies to a static library created in another directory (under policy CMP0079 NEW behavior) would incorrectly propagate usage requirements of those dependencies to dependents that link the static library. This has been fixed. The bug also existed in 3.13.0 through 3.13.4 and is fixed in 3.13.5."
Change-Id: Ic9db9050bec45d33d56ee53e3692276494f306de Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum A util/crossgcc/sum/cmake-3.14.4.tar.gz.cksum 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33053/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index fd5ce43..e99e1d3 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -60,7 +60,7 @@ # CLANG version number CLANG_VERSION=8.0.0 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.14.2 +CMAKE_VERSION=3.14.4
# GCC toolchain archive locations # These are sanitized by the jenkins toolchain test builder, so if diff --git a/util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum b/util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum deleted file mode 100644 index 6369ac3..0000000 --- a/util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -94ef8e36fa93edaf6f194e0ce0065ea769b3e57c tarballs/cmake-3.14.2.tar.gz diff --git a/util/crossgcc/sum/cmake-3.14.4.tar.gz.cksum b/util/crossgcc/sum/cmake-3.14.4.tar.gz.cksum new file mode 100644 index 0000000..c292411 --- /dev/null +++ b/util/crossgcc/sum/cmake-3.14.4.tar.gz.cksum @@ -0,0 +1 @@ +c4a25807bf80ccd4219aeb75de9a822c4d07f5b8 tarballs/cmake-3.14.4.tar.gz
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33053 )
Change subject: crossgcc: Upgrade CMake to 3.14.4 ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33053 )
Change subject: crossgcc: Upgrade CMake to 3.14.4 ......................................................................
Patch Set 2: Code-Review+1
Wait until after 4.10 release to merge
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33053
to look at the new patch set (#3).
Change subject: crossgcc: Upgrade CMake to 3.14.5 ......................................................................
crossgcc: Upgrade CMake to 3.14.5
Change: 3.14.4: "In CMake 3.14.0 through 3.14.3, calling target_link_libraries() to add PRIVATE dependencies to a static library created in another directory (under policy CMP0079 NEW behavior) would incorrectly propagate usage requirements of those dependencies to dependents that link the static library. This has been fixed. The bug also existed in 3.13.0 through 3.13.4 and is fixed in 3.13.5." 3.14.5: "Entries of the CPATH environment variable are no longer excluded from explicit use via include_directories() and target_include_directories() as they were in CMake 3.14.0 through 3.14.4"
Change-Id: Ic9db9050bec45d33d56ee53e3692276494f306de Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum A util/crossgcc/sum/cmake-3.14.5.tar.gz.cksum 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33053/3
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33053
to look at the new patch set (#4).
Change subject: crossgcc: Upgrade CMake to 3.15.0 ......................................................................
crossgcc: Upgrade CMake to 3.15.0
Changes: https://cmake.org/cmake/help/v3.15/release/3.15.html
Change-Id: Ic9db9050bec45d33d56ee53e3692276494f306de Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum A util/crossgcc/sum/cmake-3.15.0.tar.gz.cksum 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/33053/4
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33053 )
Change subject: crossgcc: Upgrade CMake to 3.15.0 ......................................................................
Patch Set 5: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33053 )
Change subject: crossgcc: Upgrade CMake to 3.15.0 ......................................................................
crossgcc: Upgrade CMake to 3.15.0
Changes: https://cmake.org/cmake/help/v3.15/release/3.15.html
Change-Id: Ic9db9050bec45d33d56ee53e3692276494f306de Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33053 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum A util/crossgcc/sum/cmake-3.15.0.tar.gz.cksum 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 30062e8..cb9838f 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -60,7 +60,7 @@ # CLANG version number CLANG_VERSION=8.0.0 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.14.2 +CMAKE_VERSION=3.15.0
# GCC toolchain archive locations # These are sanitized by the jenkins toolchain test builder, so if @@ -81,7 +81,7 @@ CRT_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/compiler-rt-$%7BCLANG_VERSION..." CTE_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/clang-tools-extra-$%7BCLANG_V..." MAKE_ARCHIVE="https://ftpmirror.gnu.org/make/make-$%7BMAKE_VERSION%7D.tar.bz2" -CMAKE_ARCHIVE="https://cmake.org/files/v3.14/cmake-$%7BCMAKE_VERSION%7D.tar.gz" +CMAKE_ARCHIVE="https://cmake.org/files/v3.15/cmake-$%7BCMAKE_VERSION%7D.tar.gz"
ALL_ARCHIVES="$GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE \ $GCC_ARCHIVE $BINUTILS_ARCHIVE $GDB_ARCHIVE $IASL_ARCHIVE \ diff --git a/util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum b/util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum deleted file mode 100644 index 6369ac3..0000000 --- a/util/crossgcc/sum/cmake-3.14.2.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -94ef8e36fa93edaf6f194e0ce0065ea769b3e57c tarballs/cmake-3.14.2.tar.gz diff --git a/util/crossgcc/sum/cmake-3.15.0.tar.gz.cksum b/util/crossgcc/sum/cmake-3.15.0.tar.gz.cksum new file mode 100644 index 0000000..3ec1605 --- /dev/null +++ b/util/crossgcc/sum/cmake-3.15.0.tar.gz.cksum @@ -0,0 +1 @@ +0a1c3870d566061da8b9ed02bbfe17a39c7bf3cd tarballs/cmake-3.15.0.tar.gz
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)