[L] Change in coreboot[main]: soc/mediatek/mt8196: Add DDP driver

[Nancy Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.

Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )

Change subject: soc/mediatek/mt8196: Add DDP driver
......................................................................

Patch Set 3:

(22 comments)

File src/soc/mediatek/mt8196/ddp.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/86bf8f97_024e6656?usp... :
PS2, Line 17: clrbits32(&reg->datapath_con, BIT(4));
            : 		setbits32(&reg->datapath_con, BIT(5));
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/4e8ecabf_3643d45f?usp... :
PS2, Line 28: 		break;
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/a11d50f6_fd6bf752?usp... :
PS2, Line 36: height << 16 | width
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/9b4b9b37_f8ce30d8?usp... :
PS2, Line 38: ff
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/bd466012_6f2cfdb6?usp... :
PS2, Line 130: 0xff
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/6fd611f0_b76375c9?usp... :
PS2, Line 196: 	/* mutex enable*/
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/02baabc1_93953a81?usp... :
PS2, Line 205: blender_config(0, width, height, FIRST_BLENDER);
             : 	blender_config(1, width, height, OTHERS);
             : 	blender_config(2, width, height, OTHERS);
             : 	blender_config(3, width, height, LAST_BLENDER);
             : 	blender_start(0);
             : 	blender_start(1);
             : 	blender_start(2);
             : 	blender_start(3);
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/70322f5d_5f1000f2?usp... :
PS2, Line 233: 	/* async config*/
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/7143d5ec_a905df49?usp... :
PS2, Line 264: 	/* exdma start*/
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/3b1131c4_c53523de?usp... :
PS2, Line 275: 0xffffffff
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/c1da9bef_abaa630e?usp... :
PS2, Line 308:
> Sorry, I think I need to check 13bit for the whole path support […]

Done

File src/soc/mediatek/mt8196/include/soc/ddp.h:

https://review.coreboot.org/c/coreboot/+/85950/comment/6da1a668_1f16699e?usp... :
PS2, Line 10: #define MAIN_PATH_OVL_NR 2
> OK, I will remove it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/1539154d_1766e3d8?usp... :
PS2, Line 15: 	/* 0x000 */
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/d93658a1_7f50daf0?usp... :
PS2, Line 58: check_member(ovlsys_cfg, rsz_in_cb2, 0xF70);
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/36bc801f_82d02dfb?usp... :
PS2, Line 110: 0xc30
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/41d64ec7_535ed17c?usp... :
PS2, Line 279: };
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/93b36fba_0166dca4?usp... :
PS2, Line 281: (void *)MMSYS_MUTEX_BASE,
             : 	(void *)MMSYS1_MUTEX_BASE,
             : 	(void *)OVLSYS_MUTEX_BASE,
> OK, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/87ded2b7_9f4a6202?usp... :
PS2, Line 286: OVL_INPUT_FORMAT
> OK, I will fix it

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/6a7015b3_524ebec7?usp... :
PS2, Line 317: /* DISPSYS mutex module*/
> OK, I will fix it

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/afd2a782_143d4bb8?usp... :
PS2, Line 343: /* DISPSYS1 mutex module*/
> OK, I will fix it

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/da87bec9_a39c83a0?usp... :
PS2, Line 365: OTHERS
> OK, I will fix it

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/b43cabb2_aa6bf88d?usp... :
PS2, Line 366: 	BLENDER_LAYER_MAX,
> OK, I will fix it

Done