Attention is currently required from: Alper Nebi Yasak, Jakub Czapiga, Maximilian Brune, Nico Huber.
Julius Werner has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80322?usp=email )
Change subject: device_tree: Add function to get top of memory from a FDT blob
......................................................................
Patch Set 4:
(2 comments)
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/80322/comment/aa8e3478_93d13c9e?usp... :
PS3, Line 181: if (be32_to_cpu(header->magic) != FDT_HEADER_MAGIC)
Sorry for being very late with all this, I've been going through execution dysfunction hell for a lo […]
At the end of the day some of these things will always remain a matter of taste, but now that CB:81081 has landed I hope we can stick to those APIs?
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/80322/comment/fe88c0f8_61647400?usp... :
PS4, Line 541:
addrcp/sizecp should be reset to 2/1 here. (Maybe it would be cleaner to just call `fdt_find_node_by_path("/")`?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80322?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8bef09bc1bc4e324ebeaa37f78d67d3aa315f52c
Gerrit-Change-Number: 80322
Gerrit-PatchSet: 4
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Comment-Date: Wed, 29 May 2024 00:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Alper Nebi Yasak
alpernebiyasak@gmail.com