Change in coreboot[master]: mb/google/octopus/variants/garg: add LTE sku to config power sequence
Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35442 )
Change subject: mb/google/octopus/variants/garg: add LTE sku to config power sequence ......................................................................
mb/google/octopus/variants/garg: add LTE sku to config power sequence
Add SKU#18 to config power sequence below: GPIOs related to power sequnce are GPIO_67 - EN_PP3300 GPIO_117 - FULL_CARD_POWER_ON_OFF GPIO_161 - PLT_RST_LTE_L 1. Power on: GPIO_67 -> 0ms -> GPIO_117 -> 30ms -> GPIO_161 2. Power off: GPIO_161 -> 30ms -> GPIO_117 -> 100ms -> GPIO_67 3. Power reset: - keep GPIO_67 and GPIO_117 high and - pull down GPIO_161 for 30ms then release it.
BUG=b:134854577,b:137033609 BRANCH=octopus TEST=build
Change-Id: I58e07518f6daaf608684c9fa1b1c88fc592ea117 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/variant.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35442/1
diff --git a/src/mainboard/google/octopus/variants/garg/variant.c b/src/mainboard/google/octopus/variants/garg/variant.c index 2754e64..942ea5f 100644 --- a/src/mainboard/google/octopus/variants/garg/variant.c +++ b/src/mainboard/google/octopus/variants/garg/variant.c @@ -25,6 +25,8 @@ SKU_1_2A2C = 1, SKU_9_HDMI = 9, SKU_17_LTE = 17, + SKU_18_LTE_TS = 18, + SKU_37_2A2C_360 = 37, };
struct gpio_with_delay { @@ -78,6 +80,7 @@
switch (get_board_sku()) { case SKU_17_LTE: + case SKU_18_LTE_TS: power_off_lte_module(slp_typ); return; default:
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35442 )
Change subject: mb/google/octopus/variants/garg: add LTE sku to config power sequence ......................................................................
Patch Set 1: Code-Review+1
I don't have permission to +2 and merging.
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35442 )
Change subject: mb/google/octopus/variants/garg: add LTE sku to config power sequence ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35442 )
Change subject: mb/google/octopus/variants/garg: add LTE sku to config power sequence ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35442 )
Change subject: mb/google/octopus/variants/garg: add LTE sku to config power sequence ......................................................................
mb/google/octopus/variants/garg: add LTE sku to config power sequence
Add SKU#18 to config power sequence below: GPIOs related to power sequnce are GPIO_67 - EN_PP3300 GPIO_117 - FULL_CARD_POWER_ON_OFF GPIO_161 - PLT_RST_LTE_L 1. Power on: GPIO_67 -> 0ms -> GPIO_117 -> 30ms -> GPIO_161 2. Power off: GPIO_161 -> 30ms -> GPIO_117 -> 100ms -> GPIO_67 3. Power reset: - keep GPIO_67 and GPIO_117 high and - pull down GPIO_161 for 30ms then release it.
BUG=b:134854577,b:137033609 BRANCH=octopus TEST=build
Change-Id: I58e07518f6daaf608684c9fa1b1c88fc592ea117 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35442 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/octopus/variants/garg/variant.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Justin TerAvest: Looks good to me, approved Marco Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/garg/variant.c b/src/mainboard/google/octopus/variants/garg/variant.c index 2754e64..942ea5f 100644 --- a/src/mainboard/google/octopus/variants/garg/variant.c +++ b/src/mainboard/google/octopus/variants/garg/variant.c @@ -25,6 +25,8 @@ SKU_1_2A2C = 1, SKU_9_HDMI = 9, SKU_17_LTE = 17, + SKU_18_LTE_TS = 18, + SKU_37_2A2C_360 = 37, };
struct gpio_with_delay { @@ -78,6 +80,7 @@
switch (get_board_sku()) { case SKU_17_LTE: + case SKU_18_LTE_TS: power_off_lte_module(slp_typ); return; default:
-
Furquan Shaikh (Code Review) -
Justin TerAvest (Code Review)
-
Kevin Chiu (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)