[M] Change in coreboot[main]: mb/google/brya/var/*: Ensure LCD device has a valid address

[Matt DeVillier (Code Review)]

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80062?usp=email )

Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................

Patch Set 1:

(1 comment)

File src/mainboard/google/brya/variants/anahera/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/80062/comment/477287de_9c946c70 :
PS1, Line 122: 0x80010400
> can u please mention the formula used to derive this hex value ?

the short answer is I copied it from the other Brya variants which did set it already 😊 (Also the same value used by the GMA driver for the LCD as device 0 on first port).

Long answer:
- bit 31 = use the ACPI-defined (vs vendor-defined) bit scheme for bits 15-0
- bit 16 = platform firmware can detect the device
- bit 10 = display type is internal/integrated flat panel (aka LCD)

from ACPI spec 6.5, table B-2.