Attention is currently required from: Hung-Te Lin, Vadim Bendebury, Furquan Shaikh, Mathew King, Paul Menzel.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57864 )
Change subject: guybrush: add RO_GSCVD area to FMAP
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/57864/comment/48167bee_c8b7ff50
PS1, Line 29: RO_GSCVD 8K
I thing RO_GSCVD should be part of the RO section, and should be updated only if WP is disabled and the RO is actually updated.
That has nothing to do with RO_SECTION though, that's just WP_RO. RO_SECTION is used among other things to calculate the RO firmware hash encoded in the HWID. For these purposes, I think it is cleaner for RO_GSCVD to be outside of RO_SECTION (the RO_SECTION hash is only supposed to change when the firmware behavior itself changes, not other metadata describing it).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa24d5a6271a8bcbf737d4580ec85b9cfdd9af01
Gerrit-Change-Number: 57864
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 23 Nov 2021 21:18:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Vadim Bendebury
vbendeb@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment