Attention is currently required from: Marc Jones, Maxim Polyakov, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49458 )
Change subject: intel/xeon_sp/util: Use get_stack_busnos instead get_cpubusnos
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49458/comment/525d98d1_d0cd5b9d
PS3, Line 7: instead
instead *of*
https://review.coreboot.org/c/coreboot/+/49458/comment/f5db8ff9_f0fa3741
PS3, Line 10: Also replace pci_io_read_config32 with
: pci_mmio_read_config32 to get the register value before mapping the
: MMIOCFG space.
Should be done in another commit (the preceding commit, maybe?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49458
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71c06c2d69344d97e48609e67a3966ed8c671152
Gerrit-Change-Number: 49458
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 15 Jan 2021 10:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment