Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36439 )
Change subject: libpayload: handle special-class-handlers before sources ......................................................................
libpayload: handle special-class-handlers before sources
This matches the coreboot makefile behavior.
Change-Id: Iaada965de904cb03edd068fed8827643496292cb Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M payloads/libpayload/Makefile 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/36439/1
diff --git a/payloads/libpayload/Makefile b/payloads/libpayload/Makefile index 1a0acf1..b1ab302 100644 --- a/payloads/libpayload/Makefile +++ b/payloads/libpayload/Makefile @@ -221,12 +221,12 @@ $(foreach class,classes subdirs $(classes) $(special-classes), $(eval $(class)-y:=)) \ $(eval -include $(1)) \ $(foreach class,$(classes-y), $(call add-class,$(class))) \ + $(foreach special,$(special-classes), \ + $(foreach item,$($(special)-y), $(call $(special)-handler,$(dir $(1)),$(item)))) \ $(foreach class,$(classes), \ $(eval $(class)-srcs+= \ $$(subst $(top)/,, \ $$(abspath $$(addprefix $(dir $(1)),$$($(class)-y)))))) \ - $(foreach special,$(special-classes), \ - $(foreach item,$($(special)-y), $(call $(special)-handler,$(dir $(1)),$(item)))) \ $(eval subdirs+=$$(subst $(CURDIR)/,,$$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y)))))
# For each path in $(subdirs) call includemakefiles
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36439 )
Change subject: libpayload: handle special-class-handlers before sources ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36439 )
Change subject: libpayload: handle special-class-handlers before sources ......................................................................
libpayload: handle special-class-handlers before sources
This matches the coreboot makefile behavior.
Change-Id: Iaada965de904cb03edd068fed8827643496292cb Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36439 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/libpayload/Makefile 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/payloads/libpayload/Makefile b/payloads/libpayload/Makefile index 1a0acf1..b1ab302 100644 --- a/payloads/libpayload/Makefile +++ b/payloads/libpayload/Makefile @@ -221,12 +221,12 @@ $(foreach class,classes subdirs $(classes) $(special-classes), $(eval $(class)-y:=)) \ $(eval -include $(1)) \ $(foreach class,$(classes-y), $(call add-class,$(class))) \ + $(foreach special,$(special-classes), \ + $(foreach item,$($(special)-y), $(call $(special)-handler,$(dir $(1)),$(item)))) \ $(foreach class,$(classes), \ $(eval $(class)-srcs+= \ $$(subst $(top)/,, \ $$(abspath $$(addprefix $(dir $(1)),$$($(class)-y)))))) \ - $(foreach special,$(special-classes), \ - $(foreach item,$($(special)-y), $(call $(special)-handler,$(dir $(1)),$(item)))) \ $(eval subdirs+=$$(subst $(CURDIR)/,,$$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y)))))
# For each path in $(subdirs) call includemakefiles