David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/variants/terrador: Add two SPD files ......................................................................
mb/google/volteer/variants/terrador: Add two SPD files
Adds SPD_LPDDR4X_432b_1R_32Gb_QDP_4267.spd.hex, which will be used initially for the "MT53E512M64D4NW-046 WT:E" Micron part as DRAM ID #7.
Adds SPD_LPDDR4X_432b_2R_64Gb_ODP_4267.spd.hex, which will be used initially for the "MT53E1G64D8NW-046 WT:E" Micron part as DRAM ID #8.
BUG=b:152936481 b:151978872 TEST=build.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ia14f76e9cb0df64961d46f4b61b39439e56f6a8c --- M src/mainboard/google/volteer/variants/terrador/Makefile.inc A src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_1R_32Gb_QDP_4267.spd.hex A src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_2R_64Gb_ODP_4267.spd.hex 3 files changed, 67 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/41995/1
diff --git a/src/mainboard/google/volteer/variants/terrador/Makefile.inc b/src/mainboard/google/volteer/variants/terrador/Makefile.inc index c9a128d..da23cf7 100644 --- a/src/mainboard/google/volteer/variants/terrador/Makefile.inc +++ b/src/mainboard/google/volteer/variants/terrador/Makefile.inc @@ -1,6 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-only
-SPD_SOURCES = +## Memory Options # DRAM ID # Part Num +SPD_SOURCES = SPD_LPDDR4X_432b_1R_32Gb_QDP_4267 # b0111 # MT53E512M64D4NW-046 WT:E +SPD_SOURCES += SPD_LPDDR4X_432b_2R_64Gb_ODP_4267 # b0100 # MT53E1G64D8NW-046 WT:E
bootblock-y += gpio.c
diff --git a/src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_1R_32Gb_QDP_4267.spd.hex b/src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_1R_32Gb_QDP_4267.spd.hex new file mode 100644 index 0000000..ef177a3 --- /dev/null +++ b/src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_1R_32Gb_QDP_4267.spd.hex @@ -0,0 +1,32 @@ +23 11 11 0E 15 21 B9 08 00 40 00 00 02 01 00 00 +00 00 04 0F 92 54 05 00 87 00 90 A8 90 C0 08 60 +04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 E5 00 E1 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_2R_64Gb_ODP_4267.spd.hex b/src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_2R_64Gb_ODP_4267.spd.hex new file mode 100644 index 0000000..2f32372 --- /dev/null +++ b/src/mainboard/google/volteer/variants/terrador/spd/SPD_LPDDR4X_432b_2R_64Gb_ODP_4267.spd.hex @@ -0,0 +1,32 @@ +23 11 11 0E 15 21 F9 08 00 40 00 00 0A 01 00 00 +49 00 04 0F 92 54 05 00 87 00 90 A8 90 C0 08 60 +04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 E5 00 E1 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Dossym Nurmukhanov, Nick Vaccaro, Sheng-Liang Pan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41995
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant terrador to mem_list_variant.txt and generates DRAM IDs allocated to these parts.
Added memory 1. MT53E512M64D4NW-046 WT:E 2. MT53E1G64D8NW-046 WT:E
BUG=b:159195585,b:152936481 TEST="emerge-volteer coreboot chromeos-bootimage", flash terrador and verify terrador boots to kernel.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ia14f76e9cb0df64961d46f4b61b39439e56f6a8c --- M src/mainboard/google/volteer/variants/terrador/Makefile.inc A src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc A src/mainboard/google/volteer/variants/terrador/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/terrador/memory/mem_list_variant.txt M src/soc/intel/tigerlake/spd/lp4x/spd_manifest.generated.txt M util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 6 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/41995/2
David Wu has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
Removed reviewer Patrick Rudolph.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Dossym Nurmukhanov, Nick Vaccaro, Zhuohao Lee, Sheng-Liang Pan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41995
to look at the new patch set (#3).
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant terrador to mem_list_variant.txt and generates DRAM IDs allocated to these parts.
Added memory 1. MT53E512M64D4NW-046 WT:E 2. MT53E1G64D8NW-046 WT:E
BUG=b:159195585,b:152936481,b:156435028 TEST="emerge-volteer coreboot chromeos-bootimage", flash terrador and verify terrador boots to kernel.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ia14f76e9cb0df64961d46f4b61b39439e56f6a8c --- M src/mainboard/google/volteer/variants/terrador/Makefile.inc A src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc A src/mainboard/google/volteer/variants/terrador/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/terrador/memory/mem_list_variant.txt M src/soc/intel/tigerlake/spd/lp4x/spd_manifest.generated.txt M util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 6 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/41995/3
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 3: Code-Review+1
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 3: -Code-Review
Could you please split this change to two CL? This first CL is generating the spd data. The second CL is the board layer change.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 4:
Patch Set 3: -Code-Review
Could you please split this change to two CL? This first CL is generating the spd data. The second CL is the board layer change.
Done. Added new CL:https://review.coreboot.org/c/coreboot/+/43060
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 4: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 4: Code-Review+2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 4: Code-Review+2
Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41995 )
Change subject: mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs ......................................................................
mb/google/volteer/var/terrador: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant terrador to mem_list_variant.txt and generates DRAM IDs allocated to these parts.
Added memory 1. MT53E512M64D4NW-046 WT:E 2. MT53E1G64D8NW-046 WT:E
BUG=b:159195585,b:152936481,b:156435028 TEST="emerge-volteer coreboot chromeos-bootimage", flash terrador and verify terrador boots to kernel.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ia14f76e9cb0df64961d46f4b61b39439e56f6a8c Reviewed-on: https://review.coreboot.org/c/coreboot/+/41995 Reviewed-by: Zhuohao Lee zhuohao@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/terrador/Makefile.inc A src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc A src/mainboard/google/volteer/variants/terrador/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/terrador/memory/mem_list_variant.txt 4 files changed, 11 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Nick Vaccaro: Looks good to me, approved Zhuohao Lee: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/terrador/Makefile.inc b/src/mainboard/google/volteer/variants/terrador/Makefile.inc index 3a7557b..b0bfc56 100644 --- a/src/mainboard/google/volteer/variants/terrador/Makefile.inc +++ b/src/mainboard/google/volteer/variants/terrador/Makefile.inc @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only
-SPD_SOURCES = - bootblock-y += gpio.c
romstage-y += memory.c diff --git a/src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc b/src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc new file mode 100644 index 0000000..fc2631c --- /dev/null +++ b/src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc @@ -0,0 +1,6 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT53E512M64D4NW-046 WT:E +SPD_SOURCES += spd-3.hex # ID = 1(0b0001) Parts = MT53E1G64D8NW-046 WT:E diff --git a/src/mainboard/google/volteer/variants/terrador/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/terrador/memory/dram_id.generated.txt new file mode 100644 index 0000000..02e7443 --- /dev/null +++ b/src/mainboard/google/volteer/variants/terrador/memory/dram_id.generated.txt @@ -0,0 +1,3 @@ +DRAM Part Name ID to assign +MT53E512M64D4NW-046 WT:E 0 (0000) +MT53E1G64D8NW-046 WT:E 1 (0001) diff --git a/src/mainboard/google/volteer/variants/terrador/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/terrador/memory/mem_list_variant.txt new file mode 100644 index 0000000..b74da4a --- /dev/null +++ b/src/mainboard/google/volteer/variants/terrador/memory/mem_list_variant.txt @@ -0,0 +1,2 @@ +MT53E512M64D4NW-046 WT:E +MT53E1G64D8NW-046 WT:E
-
David Wu (Code Review) -
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Zhuohao Lee (Code Review)